- cross-posted to:
- [email protected]
- cross-posted to:
- [email protected]
Time for a new feature update for KUP. This time I’m introducing bookmarking functionality which adds a new bookmark menu to the toolbar where you can save articles for later.
Note that the bookmarks are saved locally on the device and is mainly designed as a way to keep a reading list rather than a permanent storage of articles.
What is this?
This is a collection of hacks, fixes, enhancements and experiments that I have been tinkering with since I’ve joined Kbin, neatly packaged into one behemoth of a userscript.
Updates
0.4.0
Bookmarks
Click on the new bookmark button in the footer underneath each article to save it to your bookmarks.
A new button has been added to the toolbar which brings up a modal with all your stored bookmarks. Click on the checkmark next to the bookmark to remove it.
Compatibility with other scripts
The new bookmarks modal listens to the custom window event “hide-all-modals” for compatibility with other userscripts (like Kbin Subscriptions Panel). Dispatching that event will hide the bookmarks modal if it’s open.
0.4.1
- Fixed undefined magazine name.
0.4.2
- Improved bookmarks mobile styling.
- Moved bookmarks menu button to mobile menu for small devices. Tap the hamburger menu to access it.
0.4.3
- Bookmarks Mobile tweaks.
- Bookmarks Resetting settings now also resets bookmarks.
0.4.4
- Fixed auto preview unnecessarily reloading.
- Fixed compatibility with new version of Kbin where the KUP style settings panel has been ported to the core project.
0.4.5
Fixed numerous bugs related to recent changes in Kbin
- Fixed broken bookmarks button
- *Alt UI Fixed broken boost button
Screenshots
You must log in or # to comment.
Hi @Perry! I have two things to ask about.
-
It seems like this script doesn’t play well with KES. With both enabled, it removes the ‘Search’ Icon and puts it’s functionality on the ‘+’ icon. The old ‘+’ functionality is applied to a duplicate ‘Select a Channel’ icon, and there is additional highlighted space added to the left of the bookmark icon.
-
Would you consider integrating this script in with KES? It would be a fantastic addition.
Edit: Brave (chromium based browser) if that matters.
-
I think this has already been fixed in KES. They seem to have had compatibility issues with scripts that add icons to the toolbar menu. I was going to look into it today, but as far as I can see, things seem to be working at the moment (except for some overlapping functionality that probably shouldn’t be enabled at the same time).
-
It’s a great project they’re working on and I don’t rule out anything of course, but I feel that it somewhat goes against the very reason why I’m doing this. I see KUP as essentially a personal test bench to try out some new stuff without having to deal with code reviews or CCBs. The end goal is to see what works well and then port that functionality over to the Kbin core project.
As you might have seen, I’ve already ported parts of the KUP style settings panel to Kbin, and I have some more projects in the pipeline (that is if they are accepted into the project, which is not guaranteed of course).
Oh, it does look like it’s resolved now. 😁
Perfect! I wasn’t aware you were hoping to make these projects core code, but that makes sense! I would love for them to become part of the core software.
-
-
Ironically, I immediately found a small bug when I was going to bookmark this very article. It’s not show-stopping, but I’ll have a patch out soon.
Edit: This should be fixed in 0.4.1. Apparently my RegEx-game was not on point today, so hopefully I didn’t break something else.
Edit2: The modal doesn’t look great in mobile Safari. I’ll get a fix out asap.
Edit3: Safari issues should now be fixed in 0.4.2.
Is there a reason why not include all those features in Kbin directly by submitting a PR :)? That would be ideal, right?
I’ve found a bug: The article preview buttons disappear after page reloads if bookmarks feature is turned on.
Once they’re gone, I can toggle the “show article preview button” twice to get them to show up again, but once the page reloads, they flash briefly and disappear again. If I disable the bookmarks feature, they work as expected.
Sorry for the slow update! I’ve fixed quite a few issues, especially related to the bookmarks button, so see if it works better now!
Yeah, I found a few more bugs that was introduced as a result of the recent changes in Kbin. I’ve been away with work last week, but I’ll try to look into it in the next coming days.
@Perry I am experiencing a weird issue with KUP. Here’s a screen recording showing it: https://youtu.be/WiOSqIEht1Y
I don’t exactly know what’s going on other than it’s like lazy loaded images are reloading and sometimes loading, unloading and reloading over and over. Sometimes it’s just like an image reloads making it look like it’s flashing. But on my PC and phone (both with Firefox and Firemonkey and Tampermonkey respectively) it makes Kbin almost unusable because as I scroll down, images will pop out of existence which jumps the posts upwards, losing where I am. To get around it, when I want to tap on an upvote or go to the comments, I have to scroll really carefully so as to not let the image above from unloading.
I was using KUP v3.6 but even updating to the latest, it still has the same problem. :/
It seems like it’s triggering a reload every time it’s scrolled into view. Might be related to changes in Kbin lately or it’s just my sloppy code. I’ll try to look into it tomorrow.
Edit: This should be fixed in 0.4.4
Hey, I just enabled this and I immediately noticed a slight bug in mobile (PWA, Firefox Beta), it looks like the page is a titch wider than the screen now? I also have the kbin enhancement pack if that matters.
Does disabling the bookmark menu in settings fix the issue? It’s probably related to the extra toolbar button making the toolbar too wide on smaller devices.
I’ll look into it.
Disabling the bookmarks in settings did fix the issue, currently holding off on reenabling it.
I’ve moved the bookmarks menu button to the mobile menu for smaller devices. Tap the hamburger menu to access it.
Not 100% optimal perhaps, but I couldn’t figure out a better solution.
