Andromxda 🇺🇦🇵🇸🇹🇼@lemmy.dbzer0.com to Programmer Humor@programming.devEnglish · 2 months agofuck the testslemmy.dbzer0.comimagemessage-square46fedilinkarrow-up1851arrow-down111
arrow-up1840arrow-down1imagefuck the testslemmy.dbzer0.comAndromxda 🇺🇦🇵🇸🇹🇼@lemmy.dbzer0.com to Programmer Humor@programming.devEnglish · 2 months agomessage-square46fedilink
minus-squareRamblingPanda@lemmynsfw.comlinkfedilinkarrow-up1·2 months agoThat’s what the pipeline is for. It’s not that hard to pinpoint the commit that lead to the errors.
minus-squarePsaldorn@lemmy.worldlinkfedilinkarrow-up8·2 months agoIf I rebase my branch with main I do not expect any failing tests. If you waste my time merging shit code, fuck you. Fix your shit. Unless prod is on fire and the CEO is prowling (even then, I’d argue standards should be maintained)
minus-squareRamblingPanda@lemmynsfw.comlinkfedilinkarrow-up5·2 months agoI don’t say this is good practice, you shouldn’t even be able to merge to main with failing tests. I’ve implemented an emergency flag to do this, but I don’t want to use it in normal, daily business.
That’s what the pipeline is for. It’s not that hard to pinpoint the commit that lead to the errors.
If I rebase my branch with main I do not expect any failing tests. If you waste my time merging shit code, fuck you. Fix your shit.
Unless prod is on fire and the CEO is prowling (even then, I’d argue standards should be maintained)
I don’t say this is good practice, you shouldn’t even be able to merge to main with failing tests. I’ve implemented an emergency flag to do this, but I don’t want to use it in normal, daily business.