CareerCupid: While reviewing a merge request from a team mate who is working on a new feature, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. Your team has a document for code style guidelines, but this case is not covered there. What do you do?
cupid.careers
CareerCupid helps you find the best people, jobs and companies to work with
  • shastaxc@lemm.ee
    3·
    15 hours ago

    I would allow it and approve the PR, then I would ask the team lead if he wants to schedule time to update the style guide to cover cases like this, and set up a linter which can ideally autofix any existing code that violates that rule. Not everyone will agree with the rules set by a linter, but they ensure style consistent, and, more importantly, save everyone time and drama related to inconsequential differences in opinion (at least inconsequential to the bottom line).