What I mean is: some boolean flags are perfect for the real world phenomenon they are representing e.g. is_light_on makes you understand perfectly that when it is true the light is on and when it is false the light is off.

There are other cases in which if you didn’t write the code and you don’t read any additional documentation, everything is not clear just by looking at the variable name e.g. is_person_standing, when true it’s clear what that means but when false, is the person sitting? Lying? Kneeling?

I’m obviously not talking about cases in which there are more states, boolean would of course not be a good solution in those cases. I’m talking about programs in which there are only two states but it’s not obvious, without external knowledge, which ones they are.

  • arthur
    link
    fedilink
    English
    arrow-up
    17
    ·
    1 month ago

    I would use an Enum if available in the language:

    • More meaningful
    • Extendable
    • Lower chance of misuse
    • No naming problem
    • jbrains@sh.itjust.works
      link
      fedilink
      arrow-up
      4
      ·
      1 month ago

      Moreover, once you’re accustomed to thinking in these terms, it becomes safer to start with a boolean, because the refactoring path is clear: replace boolean with 2-value enumeration, then expand from there.